PR for Server Calling SDK Public Preview#22282
Merged
Conversation
arifsaikat-microsoft
requested review from
a team,
JianpingChen,
ankitarorabit and
minnieliu
as code owners
ghost
added
the
zhengni-msft
approved these changes
Jun 14, 2021
Member
zhengni-msft
left a comment
zhengni-msft
left a comment
There was a problem hiding this comment.
Will it for more changes with swagger review results? Change to comment status.
chrwhit
approved these changes
Jun 14, 2021
* name changes and refactoring * name changes and refactoring
Contributor
Author
Yes, these changes are mainly name changes and few contract updates based on api review feedback |
...server/src/test/java/com/azure/communication/callingserver/CallConnectionAsyncLiveTests.java
Outdated
Show resolved
Hide resolved
...server/src/test/java/com/azure/communication/callingserver/CallConnectionAsyncLiveTests.java
Outdated
Show resolved
Hide resolved
JianpingChen
approved these changes
Jun 16, 2021
...server/src/test/java/com/azure/communication/callingserver/CallConnectionAsyncLiveTests.java
Outdated
Show resolved
Hide resolved
minnieliu
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for Server Calling SDK Public Preview